Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20521#discussion_r217254430
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
 ---
    @@ -56,34 +57,36 @@ case class CreateHiveTableAsSelectCommand(
             return Seq.empty
           }
     
    -      sparkSession.sessionState.executePlan(
    -        InsertIntoTable(
    -          UnresolvedRelation(tableIdentifier),
    -          Map(),
    -          query,
    -          overwrite = false,
    -          ifPartitionNotExists = false)).toRdd
    +      InsertIntoHiveTable(
    --- End diff --
    
    @cloud-fan this change from `InsertIntoTable` to `InsertIntoHiveTable` 
introduces a regression 
[SPARK-25271](https://issues.apache.org/jira/browse/SPARK-25271), I'd like to 
revert it back to use `InsertIntoTable`, WDYT?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to