Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22413#discussion_r217513373
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
    @@ -202,7 +202,7 @@ class DataFrameReader private[sql](sparkSession: 
SparkSession) extends Logging {
               DataSourceOptions.PATHS_KEY -> 
objectMapper.writeValueAsString(paths.toArray)
             }
             Dataset.ofRows(sparkSession, DataSourceV2Relation.create(
    -          ds, extraOptions.toMap ++ sessionOptions + pathsOption,
    +          ds, sessionOptions ++ extraOptions.toMap + pathsOption,
    --- End diff --
    
    @dongjoon-hyun The commit didn't change semantic actually. Before it was:
    ```
    (extraOptions ++
            DataSourceV2Utils.extractSessionConfigs(
              ds = ds.asInstanceOf[DataSourceV2],
              conf = sparkSession.sessionState.conf))
    ```


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to