Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22417#discussion_r217667918
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/CodeGeneratorWithInterpretedFallback.scala
---
@@ -59,6 +59,6 @@ abstract class CodeGeneratorWithInterpretedFallback[IN,
OUT] extends Logging {
}
}
- protected def createCodeGeneratedObject(in: IN): OUT
+ protected def createCodeGeneratedObject(in: IN,
subexpressionEliminationEnabled: Boolean): OUT
--- End diff --
ah, yes. Looks reasonable. I'll update soon.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
