Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22227#discussion_r217901635
  
    --- Diff: R/pkg/tests/fulltests/test_sparkSQL.R ---
    @@ -1803,6 +1803,10 @@ test_that("string operators", {
         collect(select(df4, split_string(df4$a, "\\\\")))[1, 1],
         list(list("[email protected]   1", "b"))
       )
    +  expect_equal(
    +    collect(select(df4, split_string(df4$a, "\\.", 2)))[1, 1],
    +    list(list("a", "[email protected]   1\\b"))
    --- End diff --
    
    let's add a test for `limit = 0` or `limit = -1` too - while it's the 
default value, is any of the test cases changes behavior for limit = -1?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to