Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22454#discussion_r218496294
  
    --- Diff: dev/create-release/release-build.sh ---
    @@ -305,16 +290,17 @@ if [[ "$1" == "package" ]]; then
       for key in ${!BINARY_PKGS_ARGS[@]}; do
         args=${BINARY_PKGS_ARGS[$key]}
         extra=${BINARY_PKGS_EXTRA[$key]}
    -    if ! make_binary_release "$key" "2.11" "$args" "$extra"; then
    +    if ! make_binary_release "$key" "$SCALA_2_11_PROFILES $args" "$extra"; 
then
           error "Failed to build $key package. Check logs for details."
         fi
       done
     
       if [[ $PUBLISH_SCALA_2_12 = 1 ]]; then
    +    ./dev/change-scala-version.sh 2.12
         key="without-hadoop-scala-2.12"
         args="-Phadoop-provided"
         extra=""
    -    if ! make_binary_release "$key" "2.12" "$args" "$extra"; then
    +    if ! make_binary_release "$key" "$SCALA_2_12_PROFILES $args" "$extra"; 
then
           error "Failed to build $key package. Check logs for details."
         fi
    --- End diff --
    
    shall we change the scala version back to 2.11 here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to