Github user raghavgautam commented on a diff in the pull request:
https://github.com/apache/spark/pull/22414#discussion_r218530222
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/TimeWindowSuite.scala
---
@@ -122,6 +123,51 @@ class TimeWindowSuite extends SparkFunSuite with
ExpressionEvalHelper with Priva
}
}
+ test("windowDuration and slideDuration should be positive.") {
+ val fractions = Table(
+ ("windowDuration", "slideDuration"), // First tuple defines column
names
+ ("-2 seconds", "1 seconds"),
+ ("1 seconds", "-2 seconds"),
+ ("0 seconds", "1 seconds"),
+ ("1 seconds", "0 seconds"),
+ ("-2 seconds", "-2 seconds"),
+ ("-2 seconds", "-2 hours"),
+ ("0 seconds", "0 seconds"),
+ (-2L, 2L),
+ (2L, -2L),
+ (-2, 2),
+ (2, -2)
+ )
+ forAllRows(fractions) { (windowDuration: Any, slideDuration: Any) =>
+ logInfo(s"windowDuration = $windowDuration slideDuration =
$slideDuration")
--- End diff --
This will call the following function.
https://github.com/apache/spark/blob/0bdbefe9dd1e7c95c58ea6b52d3b264794abbc0e/core/src/main/scala/org/apache/spark/internal/Logging.scala#L53
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
