Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/22173#discussion_r218465153
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
---
@@ -88,6 +97,16 @@ public TransportContext(
this.conf = conf;
this.rpcHandler = rpcHandler;
this.closeIdleConnections = closeIdleConnections;
+
+ synchronized(this.getClass()) {
+ if (chunkFetchWorkers == null && conf.getModuleName() != null &&
+ conf.getModuleName().equalsIgnoreCase("shuffle")) {
+ chunkFetchWorkers = NettyUtils.createEventLoop(
+ IOMode.valueOf(conf.ioMode()),
+ conf.chunkFetchHandlerThreads(),
+ "chunk-fetch-handler");
--- End diff --
for consistency perhaps name thread shuffle-chunk-fetch-handler
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
