Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22450#discussion_r218808837
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/DecimalPrecision.scala
---
@@ -40,10 +40,13 @@ import org.apache.spark.sql.types._
* e1 + e2 max(s1, s2) + max(p1-s1, p2-s2) + 1 max(s1, s2)
* e1 - e2 max(s1, s2) + max(p1-s1, p2-s2) + 1 max(s1, s2)
* e1 * e2 p1 + p2 + 1 s1 + s2
- * e1 / e2 p1 - s1 + s2 + max(6, s1 + p2 + 1) max(6, s1 + p2 +
1)
+ * e1 / e2 max(p1-s1+s2, 0) + max(6, s1+adjP2+1) max(6,
s1+adjP2+1)
--- End diff --
This is very critical. Is there any other database using this formula?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
