Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/2659#issuecomment-62785045
  
    Actually, one question: could you check some tests into `spark-pef` that 
both check that large broadcasts don't crash _and_ ensure that the data that I 
get back is correct, byte-for-byte?  I imagine that a pretty common use-case 
for large broadcasts is binary data; in these cases, it would be hard for users 
to spot silent data corruption (since it's unlikely to cause, say, a `pickle` 
error), so I think we need to compare the actual data in our tests to make sure 
we haven't introduced corruption bugs.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to