Github user tgravescs commented on a diff in the pull request:
https://github.com/apache/spark/pull/22173#discussion_r218874415
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/util/TransportConf.java
---
@@ -281,4 +284,44 @@ public Properties cryptoConf() {
public long maxChunksBeingTransferred() {
return conf.getLong("spark.shuffle.maxChunksBeingTransferred",
Long.MAX_VALUE);
}
+
+ /**
+ * Check if it is a shuffle client
+ * and avoid creating unnecessary event loops
+ * in the TransportChannelHandler
+ */
+ public boolean shuffleClient() {
--- End diff --
I think since this is so specialized and really only used from one place
(the external shuffle service client) perhaps putting it here isn't that
useful. I think if we add a new constructor to the TransportContext with that
optional parameter it might make more sense
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
