Github user ueshin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22471#discussion_r219024051
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -2274,33 +2274,41 @@ case class Concat(children: Seq[Expression])
extends ComplexTypeMergingExpressio
override def foldable: Boolean = children.forall(_.foldable)
- override def eval(input: InternalRow): Any = dataType match {
+ override def eval(input: InternalRow): Any = evalFunction(input)
+
+ @transient private lazy val evalFunction: InternalRow => Any = dataType
match {
--- End diff --
As for `@transient`, we tend to have `@transient` for `private lazy val`
lately.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
