Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22408#discussion_r219038350
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DataFrameFunctionsSuite.scala ---
    @@ -735,6 +735,60 @@ class DataFrameFunctionsSuite extends QueryTest with 
SharedSQLContext {
           df.selectExpr("array_contains(array(1, null), array(1, null)[0])"),
           Seq(Row(true), Row(true))
         )
    +
    +    checkAnswer(
    +      df.selectExpr("array_contains(array(1), 1.23D)"),
    --- End diff --
    
    this query doesn't read any data from `df`, so the 2 result rows are always 
same. Can we use `OneRowRelation` here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to