Github user tgravescs commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21688#discussion_r219275020
  
    --- Diff: core/src/main/scala/org/apache/spark/status/api/v1/api.scala ---
    @@ -71,7 +71,9 @@ class ExecutorStageSummary private[spark](
         val shuffleWriteRecords : Long,
         val memoryBytesSpilled : Long,
         val diskBytesSpilled : Long,
    -    val isBlacklistedForStage: Boolean)
    +    val isBlacklistedForStage: Boolean,
    +    var executorLogs: Map[String, String],
    --- End diff --
    
    I don't like these being var and modified after the fact.  I think we 
should either include them from the original call or make another call, rather 
then add them in like this.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to