GitHub user WeichenXu123 opened a pull request:

    https://github.com/apache/spark/pull/22510

    [SPARK-25321][ML] Fix local LDA model constructor

    ## What changes were proposed in this pull request?
    
    change back the constructor to:
    ```
    class LocalLDAModel private[ml] (
        uid: String,
        vocabSize: Int,
        private[clustering] val oldLocalModel : OldLocalLDAModel,
        sparkSession: SparkSession)
    ```
    
    Although it is marked `private[ml]`, it is used in `mleap` and the master 
change breaks `mleap` building.
    
    ## How was this patch tested?
    
    Manual.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/WeichenXu123/spark LDA_fix

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22510.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22510
    
----
commit 2b2fdaf3f7598fe31161fdd4401728d6b314bbfe
Author: WeichenXu <weichen.xu@...>
Date:   2018-09-21T03:03:30Z

    init pr

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to