Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22518#discussion_r219667342
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala ---
@@ -166,7 +168,7 @@ case class ReuseSubquery(conf: SQLConf) extends
Rule[SparkPlan] {
val sameSchema = subqueries.getOrElseUpdate(sub.plan.schema,
ArrayBuffer[SubqueryExec]())
val sameResult = sameSchema.find(_.sameResult(sub.plan))
if (sameResult.isDefined) {
- sub.withNewPlan(sameResult.get)
+ sub.withNewPlan(sameResult.get).withNewExprId()
--- End diff --
I think it is cleaner this way. I don't expect this to happen very often
(how many subquery can you have in a plan?) so I don't think it is an issue.
But if there are cleaner options/solutions, I am open to suggestions, thanks.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
