Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/22520#discussion_r219717720
--- Diff:
core/src/main/scala/org/apache/spark/deploy/history/FsHistoryProvider.scala ---
@@ -133,9 +133,15 @@ private[history] class FsHistoryProvider(conf:
SparkConf, clock: Clock)
// Visible for testing.
private[history] val listing: KVStore = storePath.map { path =>
- val perms = PosixFilePermissions.fromString("rwx------")
- val dbPath = Files.createDirectories(new File(path,
"listing.ldb").toPath(),
- PosixFilePermissions.asFileAttribute(perms)).toFile()
+ var dbPath : File = null
--- End diff --
Nit: no space before colon. Rather than make a var and assign to null, just
assign `val dbPath = ...` to the result of the if statement.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
