Github user HyukjinKwon commented on a diff in the pull request: https://github.com/apache/spark/pull/22533#discussion_r219811169 --- Diff: python/pyspark/sql/window.py --- @@ -76,12 +79,37 @@ def partitionBy(*cols): @staticmethod @since(1.4) - def orderBy(*cols): + def orderBy(*cols, **kwargs): """ Creates a :class:`WindowSpec` with the ordering defined. + + :param cols: names of columns or expressions. --- End diff -- We should add ` ... versionchanged:: 2.5 blah blah` BTW
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org