Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/22504#discussion_r220013762
--- Diff: core/src/main/scala/org/apache/spark/internal/Logging.scala ---
@@ -192,7 +207,16 @@ private[spark] object Logging {
defaultSparkLog4jConfig = false
LogManager.resetConfiguration()
} else {
- LogManager.getRootLogger().setLevel(defaultRootLevel)
+ val rootLogger = LogManager.getRootLogger()
+ rootLogger.setLevel(defaultRootLevel)
+ val appenders = rootLogger.getAllAppenders
+ while (appenders.hasMoreElements()) {
+ val tmp = appenders.nextElement()
+ tmp match {
+ case ca: ConsoleAppender => ca.setThreshold(defaultRootLevel)
--- End diff --
You'll need to reset this to the appender's original level (not to the root
logger's original level, which may be different).
In fact you're not really setting the root logger level anymore, right? So
`defaultRootLevel` doesn't really make much sense with your changes.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
