Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22540#discussion_r220065308
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
    @@ -1295,15 +1295,15 @@ object SQLConf {
           .booleanConf
           .createWithDefault(true)
     
    -  val PANDAS_GROUPED_MAP_ASSIGN_COLUMNS_BY_POSITION =
    -    
buildConf("spark.sql.execution.pandas.groupedMap.assignColumnsByPosition")
    +  val PANDAS_GROUPED_MAP_ASSIGN_COLUMNS_BY_NAME =
    +    
buildConf("spark.sql.legacy.execution.pandas.groupedMap.assignColumnsByName")
    --- End diff --
    
    Actually, we are not following this in the other SQLConf. I think either is 
fine. We will remove these SQLConf in Spark 3.0 release. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to