Github user dilipbiswal commented on a diff in the pull request:
https://github.com/apache/spark/pull/22544#discussion_r220250631
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/TypeCoercion.scala
---
@@ -971,9 +971,36 @@ object TypeCoercion {
case (ArrayType(fromType, true), ArrayType(toType: DataType,
false)) => null
case (ArrayType(fromType, false), ArrayType(toType: DataType,
false))
- if !Cast.forceNullable(fromType, toType) =>
+ if !Cast.forceNullable(fromType, toType) =>
implicitCast(fromType, toType).map(ArrayType(_, false)).orNull
+ // Implicit cast between Map types.
--- End diff --
@viirya actually i followed the arraytype example. Actually it has decent
coverage, i think. If you can think of a case thats missing , i will add. I
will also go through once again myself.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
