Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22490#discussion_r220413714
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/vectorized/ColumnarBatchBenchmark.scala
 ---
    @@ -30,8 +30,15 @@ import org.apache.spark.util.collection.BitSet
     
     /**
      * Benchmark to low level memory access using different ways to manage 
buffers.
    + * To run this benchmark:
    + * {{{
    + *   1. without sbt: bin/spark-submit --class <this class> <spark sql test 
jar>
    + *   2. build/sbt "sql/test:runMain <this class>"
    + *   3. generate result: SPARK_GENERATE_BENCHMARK_FILES=1 build/sbt 
"sql/test:runMain <this class>"
    + *      Results will be written to "benchmarks/<this class>-results.txt".
    --- End diff --
    
    Could you put the name `ColumnarBatchBenchmark` instead of `<this class>` 
at line 38? In the same document, this one `<this class>` means a different 
value from the other two.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to