Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/3253#discussion_r20320583
--- Diff: network/common/pom.xml ---
@@ -51,7 +51,6 @@
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
- <version>11.0.2</version> <!-- yarn 2.4.0's version -->
--- End diff --
So, the reason why this re-declaration exists is because network/yarn,
which depends on this library, is expected to run inside Yarn's NM, and Yarn
depends on Guava 11. So this is trying to avoid using newer Guava APIs so that
we don't need to do unsanitary things like shading Guava in the NM plugin jar.
I'm OK with removing this if people feel like we'll always remember to
audit the usage of Guava in this module, but I'd prefer an approach that keeps
the 11.0.2 dependency at least on the maven build (which generates the official
Spark artifacts). That could be done by using a property to hold this version
and re-defining it to 11.0.2 in the sbt profile, or re-declaring the dependency
in SparkBuild.scala as I tried (see the discussion in the bug).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
