Github user sandeep-katta commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22466#discussion_r220564446
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/ddl.scala ---
    @@ -66,6 +66,19 @@ case class CreateDatabaseCommand(
       extends RunnableCommand {
     
       override def run(sparkSession: SparkSession): Seq[Row] = {
    +    // SPARK-25464 fail if DB location exists and is not empty
    +    if (path.isDefined) {
    --- End diff --
    
    The reason I did here is, external catalog always have path (default or 
user specified),so we end up in checking the path always.This may be the costly 
operation if the file system is S3


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to