Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/22326
  
    LGTM except some unnecessary end-to-end tests.
    
    +1 for @mgaido91 's idea about unit test, something like the test suites 
under `org.apache.spark.sql.catalyst.optimizer`. I'm ok to do it in a followup, 
since it will be the first UT for python rules.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to