GitHub user gengliangwang opened a pull request:
https://github.com/apache/spark/pull/22562
[SPARK-25541][SQL][FOLLOWUP] Remove overriding filterKeys in
CaseInsensitiveMap
## What changes were proposed in this pull request?
As per the discussion in
https://github.com/apache/spark/pull/22553#pullrequestreview-159192221,
override `filterKeys` violates the documented semantics.
This PR is to remove it and add documentation.
Also fix one potential non-serializable map in `FileStreamOptions`.
The only one call of `CaseInsensitiveMap`'s `filterKeys` left is
https://github.com/apache/spark/blob/c3c45cbd76d91d591d98cf8411fcfd30079f5969/sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/HiveOptions.scala#L88-L90
But this one is OK.
## How was this patch tested?
Existing unit tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gengliangwang/spark SPARK-25541-FOLLOWUP
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22562
----
commit 10d89f414f40fa2303b95908a1ab1d2a605b6ec4
Author: Gengliang Wang <gengliang.wang@...>
Date: 2018-09-27T02:45:43Z
remove overriding filterKeys
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
