Github user rezazadeh commented on a diff in the pull request:
https://github.com/apache/spark/pull/3200#discussion_r20330160
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
---
@@ -0,0 +1,331 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.mllib.linalg.distributed
+
+import breeze.linalg.{DenseMatrix => BDM}
+
+import org.apache.spark._
+import org.apache.spark.mllib.linalg.DenseMatrix
+import org.apache.spark.rdd.RDD
+import org.apache.spark.storage.StorageLevel
+import org.apache.spark.util.Utils
+
+/**
+ * Represents a local matrix that makes up one block of a distributed
BlockMatrix
+ *
+ * @param blockIdRow The row index of this block
+ * @param blockIdCol The column index of this block
+ * @param mat The underlying local matrix
+ */
+case class BlockPartition(blockIdRow: Int, blockIdCol: Int, mat:
DenseMatrix) extends Serializable
+
+/**
+ * Information about the BlockMatrix maintained on the driver
+ *
+ * @param partitionId The id of the partition the block is found in
+ * @param blockIdRow The row index of this block
+ * @param blockIdCol The column index of this block
+ * @param startRow The starting row index with respect to the distributed
BlockMatrix
+ * @param numRows The number of rows in this block
+ * @param startCol The starting column index with respect to the
distributed BlockMatrix
+ * @param numCols The number of columns in this block
+ */
+case class BlockPartitionInfo(
+ partitionId: Int,
+ blockIdRow: Int,
+ blockIdCol: Int,
+ startRow: Long,
+ numRows: Int,
+ startCol: Long,
+ numCols: Int) extends Serializable
+
+/**
+ * A partitioner that decides how the matrix is distributed in the cluster
+ *
+ * @param numPartitions Number of partitions
+ * @param rowPerBlock Number of rows that make up each block.
+ * @param colPerBlock Number of columns that make up each block.
+ */
+abstract class BlockMatrixPartitioner(
+ override val numPartitions: Int,
+ val rowPerBlock: Int,
+ val colPerBlock: Int) extends Partitioner {
+ val name: String
+
+ override def getPartition(key: Any): Int = {
+ Utils.nonNegativeMod(key.asInstanceOf[Int], numPartitions)
+ }
+}
+
+/**
+ * A grid partitioner, which stores every block in a separate partition.
+ *
+ * @param numRowBlocks Number of blocks that form the rows of the matrix.
+ * @param numColBlocks Number of blocks that form the columns of the
matrix.
+ * @param rowPerBlock Number of rows that make up each block.
+ * @param colPerBlock Number of columns that make up each block.
+ */
+class GridPartitioner(
+ val numRowBlocks: Int,
+ val numColBlocks: Int,
+ override val rowPerBlock: Int,
+ override val colPerBlock: Int)
+ extends BlockMatrixPartitioner(numRowBlocks * numColBlocks, rowPerBlock,
colPerBlock) {
+
+ override val name = "grid"
+
+ override val numPartitions = numRowBlocks * numColBlocks
+
+ override def equals(obj: Any): Boolean = {
+ obj match {
+ case r: GridPartitioner =>
+ (this.numPartitions == r.numPartitions) && (this.rowPerBlock ==
r.rowPerBlock) &&
+ (this.colPerBlock == r.colPerBlock)
+ case _ =>
+ false
+ }
+ }
+}
+
+/**
+ * A specialized partitioner that stores all blocks in the same row in
just one partition.
+ *
+ * @param numPartitions Number of partitions. Should be set as the number
of blocks that form
+ * the rows of the matrix.
+ * @param rowPerBlock Number of rows that make up each block.
+ * @param colPerBlock Number of columns that make up each block.
+ */
+class RowBasedPartitioner(
+ override val numPartitions: Int,
+ override val rowPerBlock: Int,
+ override val colPerBlock: Int)
+ extends BlockMatrixPartitioner(numPartitions, rowPerBlock, colPerBlock) {
+
+ override val name = "row"
+
+ override def equals(obj: Any): Boolean = {
+ obj match {
+ case r: RowBasedPartitioner =>
+ (this.numPartitions == r.numPartitions) && (this.rowPerBlock ==
r.rowPerBlock) &&
+ (this.colPerBlock == r.colPerBlock)
+ case _ =>
+ false
+ }
+ }
+}
+
+/**
+ * A specialized partitioner that stores all blocks in the same column in
just one partition.
+ *
+ * @param numPartitions Number of partitions. Should be set as the number
of blocks that form
+ * the columns of the matrix.
+ * @param rowPerBlock Number of rows that make up each block.
+ * @param colPerBlock Number of columns that make up each block.
+ */
+class ColumnBasedPartitioner(
+ override val numPartitions: Int,
+ override val rowPerBlock: Int,
+ override val colPerBlock: Int)
+ extends BlockMatrixPartitioner(numPartitions, rowPerBlock, colPerBlock) {
+
+ override val name = "column"
+
+ override def equals(obj: Any): Boolean = {
+ obj match {
+ case p: ColumnBasedPartitioner =>
+ (this.numPartitions == p.numPartitions) && (this.rowPerBlock ==
p.rowPerBlock) &&
+ (this.colPerBlock == p.colPerBlock)
+ case r: RowBasedPartitioner =>
+ (this.numPartitions == r.numPartitions) && (this.colPerBlock ==
r.rowPerBlock)
+ case _ =>
+ false
+ }
+ }
+}
+
+/**
+ * Represents a distributed matrix in blocks of local matrices.
+ *
+ * @param numRowBlocks Number of blocks that form the rows of this matrix
+ * @param numColBlocks Number of blocks that form the columns of this
matrix
+ * @param rdd The RDD of BlockPartitions (local matrices) that form this
matrix
+ * @param partitioner A partitioner that specifies how BlockPartitions are
stored in the cluster
+ */
+class BlockMatrix(
+ val numRowBlocks: Int,
+ val numColBlocks: Int,
+ val rdd: RDD[BlockPartition],
+ val partitioner: BlockMatrixPartitioner) extends DistributedMatrix
with Logging {
+
+ // A key-value pair RDD is required to partition properly
+ private var matrixRDD: RDD[(Int, BlockPartition)] = keyBy()
+
+ @transient var blockInfo_ : Map[(Int, Int), BlockPartitionInfo] = null
+
+ private lazy val dims: (Long, Long) = getDim
+
+ override def numRows(): Long = dims._1
+ override def numCols(): Long = dims._2
+
+ if (partitioner.name.equals("column")) {
+ require(numColBlocks == partitioner.numPartitions, "The number of
column blocks should match" +
--- End diff --
Output the non-equal parameters here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
