Github user dilipbiswal commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22566#discussion_r221029986
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/command/AnalyzeColumnCommand.scala
 ---
    @@ -50,7 +52,26 @@ case class AnalyzeColumnCommand(
         val sizeInBytes = CommandUtils.calculateTotalSize(sparkSession, 
tableMeta)
     
         // Compute stats for each column
    -    val (rowCount, newColStats) = computeColumnStats(sparkSession, 
tableIdentWithDB, columnNames)
    +    val conf = sparkSession.sessionState.conf
    +    val relation = sparkSession.table(tableIdent).logicalPlan
    +    val attributesToAnalyze = if (allColumns) {
    +      relation.output
    --- End diff --
    
    @gatorsmile I think we don't allow it any more. Please see 
[test](https://github.com/dilipbiswal/spark/blob/7920b29f667de38ca5222e4de8f62eea688d67e4/sql/core/src/test/scala/org/apache/spark/sql/FileBasedDataSourceSuite.scala#L111:L136).
 Please let me know what you think..


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to