Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21669#discussion_r221677518
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/security/KubernetesHadoopDelegationTokenManager.scala
 ---
    @@ -0,0 +1,77 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.k8s.security
    +
    +import java.io.File
    +
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.hadoop.fs.FileSystem
    +import org.apache.hadoop.security.{Credentials, UserGroupInformation}
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.deploy.SparkHadoopUtil
    +import org.apache.spark.deploy.security.HadoopDelegationTokenManager
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.util.{Clock, SystemClock}
    +
    + /**
    +  * The KubernetesHadoopDelegationTokenManager fetches Hadoop delegation 
tokens
    +  * on the behalf of the Kubernetes submission client. The new credentials
    +  * (called Tokens when they are serialized) are stored in Secrets 
accessible
    +  * to the driver and executors, when new Tokens are received they 
overwrite the current Secrets.
    +  */
    +private[spark] class KubernetesHadoopDelegationTokenManager extends 
Logging {
    --- End diff --
    
    Why do you need this class if the only thing it does is to use a 
`HadoopDelegationTokenManager` to get a DT? Looks like you can use 
`HadoopDelegationTokenManager` directly?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to