Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22596#discussion_r221835152
  
    --- Diff: 
common/unsafe/src/test/java/org/apache/spark/unsafe/types/UTF8StringSuite.java 
---
    @@ -63,7 +63,6 @@ public void basicTest() {
         checkBasic("hello", 5); // 5 * 1 byte chars
         checkBasic("大 千 世 界", 7);
         checkBasic("︽﹋%", 3); // 3 * 3 bytes chars
    -    checkBasic("\uD83E\uDD19", 1); // 4 bytes char
    --- End diff --
    
    We should not remove test coverage.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to