GitHub user phegstrom reopened a pull request:

    https://github.com/apache/spark/pull/22227

    [SPARK-25202] [SQL] Implements split with limit sql function

    ## What changes were proposed in this pull request?
    
    Adds support for the setting limit in the sql split function
    
    ## How was this patch tested?
    
    1. Updated unit tests
    2. Tested using Scala spark shell
    
    Please review http://spark.apache.org/contributing.html before opening a 
pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/phegstrom/spark master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/22227.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #22227
    
----
commit 15362be4764d2b33757488efe38667cc762246ad
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-24T19:19:58Z

    implement split with limit

commit ceb3f41238c8731606164cea5c45a0b87bb5d6f2
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-24T20:26:42Z

    linting

commit e564a68ce8db001f5ebcec49bbeb8a4b893a8d70
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-27T20:27:45Z

    most comments

commit 4e107337a47ce590c703b757b0a44d60d6b862e1
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-27T21:01:14Z

    sql function tests

commit 5135cb28e505f5c61ce325ac6e5589b35450b44a
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-28T21:52:25Z

    fixing test file, comments

commit e8c8c8c5e3811fd8e8f2c7b8c77ae404b4acc157
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-28T21:57:24Z

    adding another example

commit 8e163283a71fa272ae8d7c43632e38ef01f8d12b
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-30T13:57:53Z

    better docs, fixing sql output files

commit ca23ea363fe2beaecc4cf16385256aabbdd7d626
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-30T15:01:36Z

    adding python support

commit 96bc875d4790f46f72e30c4845c25ed5c4dc73cc
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-30T15:22:17Z

    fixing style checks

commit 79599ebc26f089737e101b417428ceb6620f802d
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-30T18:46:01Z

    adding support for R

commit a27c848a62a08c869699bd521092987672337926
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-30T21:07:28Z

    ammending doc format

commit fa128db516be00a145af58a595143d7ccc31b7a4
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-30T21:13:06Z

    fixing typo

commit a6411069c352b30f9094a83991c35f0730b5df55
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-31T01:58:07Z

    fix docs to check ci status

commit 7e4ba981ef4636b5663f1a50df6e3fa8886186c3
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-31T17:44:09Z

    add fallback from limit = 0, update tests

commit d80b1a15ed8941bad78df2c5f7168a4196d27be4
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-08-31T21:19:11Z

    fix python syntax in tests

commit d17d2df530a9236471b415700533c9224c94435a
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-09-01T15:39:04Z

    bring limit handling into UTF8String split impl

commit 64b0afca802c4557b5a53aa62b7486c3d8d4fe8c
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-09-06T19:57:37Z

    HyukjinKwon comments

commit 4e84df0a80c1e610068884f937b73478be7e1c1c
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-09-07T16:16:17Z

    removing duplicate pattern reference

commit b12ee881c1d9025644d075a6124f9e6e465a6378
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-09-10T10:04:28Z

    docs comments, change to 3.0

commit 69d219018c9b2a7f3fb7dd716619f067aec0d2dc
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-09-12T11:58:42Z

    docs comments

commit b5994ad66c355cf104c1bd4b1e75ae2e6cc199c3
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-09-14T10:55:55Z

    docs comments, should be good to go

commit 5c8f48715748bdeda703761fba6a4d1828a19985
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-09-16T22:46:43Z

    felix comments for R tests

commit 34ba74f79aad2a0e2fe9e0d6f6110a10a51c8108
Author: Parker Hegstrom <phegstrom@...>
Date:   2018-10-01T18:18:06Z

    viirya comments

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to