Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22602#discussion_r221955172
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/codegen/UnsafeWriterSuite.scala
 ---
    @@ -0,0 +1,43 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.catalyst.expressions.codegen
    +
    +import org.apache.spark.SparkFunSuite
    +import org.apache.spark.sql.types.Decimal
    +
    +class UnsafeWriterSuite extends SparkFunSuite {
    +
    +  test("SPARK-25538: zero-out all bits for decimals") {
    +    // This decimal holds 8 bytes
    +    val decimal1 = Decimal(0.431)
    +    decimal1.changePrecision(38, 18)
    +    // This decimal holds 11 bytes
    +    val decimal2 = Decimal(123456789.1232456789)
    +    decimal2.changePrecision(38, 18)
    +    val unsafeRowWriter = new UnsafeRowWriter(1)
    +    unsafeRowWriter.resetRowWriter()
    +    unsafeRowWriter.write(0, decimal2, decimal2.precision, decimal2.scale)
    +    unsafeRowWriter.reset()
    +    unsafeRowWriter.write(0, decimal1, decimal1.precision, decimal1.scale)
    +    val res = unsafeRowWriter.getRow
    +    assert(res.getDecimal(0, decimal1.precision, decimal1.scale) == 
decimal1)
    --- End diff --
    
    then this doesn't demonstrate how this bug could affect correctness.
    
    one better idea for this test: we create 2 row writers, one writes the 
decimal as what you did here, and the other one writes decimal `0.431` 
directly. Then we compare the 2 result rows and make sure they equals.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to