Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3262#discussion_r20346755
  
    --- Diff: core/src/test/scala/org/apache/spark/ImplicitSuite.scala ---
    @@ -0,0 +1,73 @@
    +package org.apache.spark
    +
    +/**
    + * A test suite to make sure all `implicit` functions work correctly.
    + * Please don't `import org.apache.spark.SparkContext._` in this class.
    + *
    + * As `implicit` is a compiler feature, we don't need to run this class.
    + * What we need to do is making the compiler happy.
    + */
    +class ImplicitSuite {
    +
    +
    +  // We only want to test if `implict` works well with the compiler, so we 
don't need a real
    +  // SparkContext.
    +  def mockSparkContext[T]: org.apache.spark.SparkContext = null
    +
    +  // We only want to test if `implict` works well with the compiler, so we 
don't need a real RDD.
    +  def mockRDD[T]: org.apache.spark.rdd.RDD[T] = null
    +
    +  def testRddToPairRDDFunctions(): Unit = {
    +    val rdd: org.apache.spark.rdd.RDD[(Int, Int)] = mockRDD
    +    rdd.groupByKey
    --- End diff --
    
    can u add parentheses to groupByKey?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to