Github user mccheah commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r222486977
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -84,6 +122,8 @@ case object MappedPoolMemory extends
MBeanExecutorMetricType(
"java.nio:type=BufferPool,name=mapped")
private[spark] object ExecutorMetricType {
+ final val pTreeInfo = new ProcfsBasedSystems
--- End diff --
Can ProcfsBasedSystems just be an `object` in and of itself?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
