Github user maropu commented on a diff in the pull request:
https://github.com/apache/spark/pull/22512#discussion_r222534352
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/literals.scala
---
@@ -162,6 +163,14 @@ object Literal {
Literal(CatalystTypeConverters.convertToCatalyst(v), dataType)
--- End diff --
I think this API (`def create(v: Any, dataType: DataType): Literal`) might
be a little obscure: `create(scalaValue, dataType)` vs `create(catalystValue,
dataType)`. How about splitting this API into the two below?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
