Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22622#discussion_r222535254
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/orc/OrcSourceSuite.scala
---
@@ -284,4 +350,8 @@ class OrcSourceSuite extends OrcSuite with
SharedSQLContext {
test("Check BloomFilter creation") {
testBloomFilterCreation(Kind.BLOOM_FILTER_UTF8) // After ORC-101
}
+
+ test("Enforce direct encoding column-wise selectively") {
+ testSelectiveDictionaryEncoding(true)
--- End diff --
how about `testSelectiveDictionaryEncoding(isSelective = true)`
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
