Github user cristianopris commented on the pull request:
https://github.com/apache/spark/pull/3259#issuecomment-63068893
Hi Josh, thanks for looking into this.
I'm not sure this fully fixes the issue though. In my heap dump it looks
like the memory leak is caused by the TimerTask holding a reference to the
Promise, which would hold a reference to the message when it's set succesfully.
A suggested fix would be to override cancel in the TimerTask to set the promise
reference to null if the task is cancelled (and the run() method will not
actually get to run).
I've put a comment at the respective line in "Files changed" to indicate
where the issue is.
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
