Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22630#discussion_r222855008
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegenExec.scala
 ---
    @@ -345,6 +345,16 @@ trait CodegenSupport extends SparkPlan {
        * don't require shouldStop() in the loop of producing rows.
        */
       def needStopCheck: Boolean = parent.needStopCheck
    +
    +  def conditionsOfKeepProducingData: Seq[String] = 
parent.conditionsOfKeepProducingData
    --- End diff --
    
    Can we have described simply what this two method are here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to