Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22630#discussion_r223027028
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
 ---
    @@ -518,56 +521,81 @@ class SQLMetricsSuite extends SparkFunSuite with 
SQLMetricsTestUtils with Shared
         testMetricsDynamicPartition("parquet", "parquet", "t1")
       }
     
    +  private def collectNodeWithinWholeStage[T <: SparkPlan : ClassTag](plan: 
SparkPlan): Seq[T] = {
    +    val stages = plan.collect {
    --- End diff --
    
    we also want to detect the case of 2 whole stage codegen and fail.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to