GitHub user gatorsmile opened a pull request:
https://github.com/apache/spark/pull/22647
[SPARK-25655] [BUILD] Add Pspark-ganglia-lgpl to the scala style check.
## What changes were proposed in this pull request?
Our lint failed due to the following errors:
```
[INFO] --- scalastyle-maven-plugin:1.0.0:check (default) @
spark-ganglia-lgpl_2.11 ---
error
file=/home/jenkins/workspace/spark-master-maven-snapshots/spark/external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala
message=
Are you sure that you want to use toUpperCase or toLowerCase without
the root locale? In most cases, you
should use toUpperCase(Locale.ROOT) or toLowerCase(Locale.ROOT)
instead.
If you must use toUpperCase or toLowerCase without the root locale,
wrap the code block with
// scalastyle:off caselocale
.toUpperCase
.toLowerCase
// scalastyle:on caselocale
line=67 column=49
error
file=/home/jenkins/workspace/spark-master-maven-snapshots/spark/external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala
message=
Are you sure that you want to use toUpperCase or toLowerCase without
the root locale? In most cases, you
should use toUpperCase(Locale.ROOT) or toLowerCase(Locale.ROOT)
instead.
If you must use toUpperCase or toLowerCase without the root locale,
wrap the code block with
// scalastyle:off caselocale
.toUpperCase
.toLowerCase
// scalastyle:on caselocale
line=71 column=32
Saving to
outputFile=/home/jenkins/workspace/spark-master-maven-snapshots/spark/external/spark-ganglia-lgpl/target/scalastyle-output.xml
```
See
https://amplab.cs.berkeley.edu/jenkins/view/Spark%20QA%20Compile/job/spark-master-lint/8890/
## How was this patch tested?
N/A
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/gatorsmile/spark fixLint
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/22647.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22647
----
commit b41e3f246982549e0a53fc2f5fe738dce01d8a1d
Author: gatorsmile <gatorsmile@...>
Date: 2018-10-05T20:33:54Z
fix style
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
