Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/22532
  
    Thanks for submitting the PR! I quickly scan the code changes. It sounds 
like the general direction is right but the quality is not ready. 
    
    I would suggest to write the test plan before doing the code review. Could 
you try your best to write down what we should test for supporting this 
feature? Both negative and positive cases. 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to