Github user kiszk commented on a diff in the pull request:
https://github.com/apache/spark/pull/22375#discussion_r223169637
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CodeGenerationSuite.scala
---
@@ -113,7 +113,7 @@ class CodeGenerationSuite extends SparkFunSuite with
ExpressionEvalHelper {
assert(actual.length == 1)
val expected = UTF8String.fromString("abc")
- if (!checkResult(actual.head, expected, expressions.head.dataType)) {
+ if (!checkResult(actual.head, expected, expressions.head.dataType,
expressions.head.nullable)) {
--- End diff --
That is another option that I thought. On the other hand, to set default
has a risk to overlook a possible incosistency between value and `nullable` at
top level of `expected`.
Do we use the default value at the all of callers of `checkResult`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
