Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/22647#discussion_r223182808
--- Diff:
external/spark-ganglia-lgpl/src/main/scala/org/apache/spark/metrics/sink/GangliaSink.scala
---
@@ -64,11 +64,12 @@ class GangliaSink(val property: Properties, val
registry: MetricRegistry,
val ttl =
propertyToOption(GANGLIA_KEY_TTL).map(_.toInt).getOrElse(GANGLIA_DEFAULT_TTL)
val dmax =
propertyToOption(GANGLIA_KEY_DMAX).map(_.toInt).getOrElse(GANGLIA_DEFAULT_DMAX)
val mode: UDPAddressingMode = propertyToOption(GANGLIA_KEY_MODE)
- .map(u =>
GMetric.UDPAddressingMode.valueOf(u.toUpperCase)).getOrElse(GANGLIA_DEFAULT_MODE)
+ .map(u =>
GMetric.UDPAddressingMode.valueOf(u.toUpperCase(Locale.Root)))
--- End diff --
it should be `Locale.ROOT`
I don't know how the jenkins passed the test, can someone check the jenkins
script and see if this ganglia module is totally skipped by jenkins?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
