Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/3204#discussion_r20390122
--- Diff:
core/src/main/scala/org/apache/spark/ExecutorAllocationManager.scala ---
@@ -217,14 +229,24 @@ private[spark] class ExecutorAllocationManager(sc:
SparkContext) extends Logging
numExecutorsToAdd = 1
return 0
}
+ val maxExecutorsPending =
maxExecutorsNeededForTasks(listener.totalPendingTasks())
+ if (numExecutorsPending >= maxExecutorsPending) {
+ logDebug(s"Not adding executors because there are already
$numExecutorsPending " +
+ s"pending and pending tasks could only fill $maxExecutorsPending")
+ numExecutorsToAdd = 1
+ return 0
+ }
+
+ // It's never useful to request more executors than could satisfy all
the pending tasks, so
+ // cap request at that amount.
+ // Also cap request with respect to the configured upper bound.
+ val maxExecutorsToAdd = math.min(
--- End diff --
I would call this `maxNumExecutorsToAdd`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
