Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20761#discussion_r223435325
  
    --- Diff: 
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/ClientSuite.scala
 ---
    @@ -199,6 +200,37 @@ class ClientSuite extends SparkFunSuite with Matchers {
         appContext.getMaxAppAttempts should be (42)
       }
     
    +  test("resource request for invalid resource") {
    --- End diff --
    
    Is this testing any Spark code at all? It seems to just be a long way to 
test YARN code that checks whether a resource type has been registered.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to