Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/22173#discussion_r223513440
--- Diff:
common/network-common/src/main/java/org/apache/spark/network/TransportContext.java
---
@@ -77,17 +82,54 @@
private static final MessageEncoder ENCODER = MessageEncoder.INSTANCE;
private static final MessageDecoder DECODER = MessageDecoder.INSTANCE;
+ // Separate thread pool for handling ChunkFetchRequest. This helps to
enable throttling
+ // max number of TransportServer worker threads that are blocked on
writing response
+ // of ChunkFetchRequest message back to the client via the underlying
channel.
+ private static EventLoopGroup chunkFetchWorkers;
--- End diff --
Is there any special reason that this must be a global one? I have not yet
looked the details. But looks like this may cause ChunkFetchIntegrationSuite
flaky as there is no isolation between tests.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
