Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21732#discussion_r223691061
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
 ---
    @@ -358,4 +358,31 @@ class ScalaReflectionSuite extends SparkFunSuite {
         assert(numberOfCheckedArguments(deserializerFor[(java.lang.Double, 
Int)]) == 1)
         assert(numberOfCheckedArguments(deserializerFor[(java.lang.Integer, 
java.lang.Integer)]) == 0)
       }
    +
    +  test("SPARK-24762: serializer for Option of Product") {
    +    val optionOfProduct = Some((1, "a"))
    --- End diff --
    
    why do we need this? we can write `classOf[Option[(Int, String)]]` below.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to