Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22237#discussion_r223708500
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/jsonExpressions.scala
 ---
    @@ -554,18 +554,30 @@ case class JsonToStructs(
       @transient
       lazy val converter = nullableSchema match {
         case _: StructType =>
    -      (rows: Seq[InternalRow]) => if (rows.length == 1) rows.head else null
    +      (rows: Iterator[InternalRow]) => if (rows.hasNext) rows.next() else 
null
    --- End diff --
    
    so we may still return null in some cases, can you list them?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to