Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22676#discussion_r223728765
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVHeaderChecker.scala
 ---
    @@ -0,0 +1,131 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.sql.execution.datasources.csv
    +
    +import com.univocity.parsers.csv.CsvParser
    +
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.sql.internal.SQLConf
    +import org.apache.spark.sql.types.StructType
    +
    +/**
    + * Checks that column names in a CSV header and field names in the schema 
are the same
    + * by taking into account case sensitivity.
    + *
    + * @param schema provided (or inferred) schema to which CSV must conform.
    + * @param options parsed CSV options.
    + * @param source name of CSV source that are currently checked. It is used 
in error messages.
    + * @param isStartOfFile indicates if the currently processing partition is 
the start of the file.
    + *                      if unknown or not applicable (for instance when 
the input is a dataset),
    + *                      can be omitted.
    + */
    +class CSVHeaderChecker(
    --- End diff --
    
    It's under execution package which is meant to be private. Since it's 
accessed in DataFrameReader, it should be `private[sql]` which is removed in 
SPARK-16964 for this reason.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to