Github user fjh100456 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22641#discussion_r223914298
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/CompressionCodecSuite.scala
---
@@ -262,7 +261,10 @@ class CompressionCodecSuite extends TestHiveSingleton
with ParquetTest with Befo
}
}
- def checkForTableWithCompressProp(format: String, compressCodecs:
List[String]): Unit = {
+ def checkForTableWithCompressProp(
+ format: String,
+ tableCompressCodecs: List[String],
+ sessionCompressCodecs: List[String]): Unit = {
Seq(true, false).foreach { isPartitioned =>
--- End diff --
This combination provides different test scenariosï¼they are not quite the
same on writing data and table property passing, all of which have the
potential to affect the test results. So I think it's necessary to keep.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
