Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/22009#discussion_r224023061
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Relation.scala
---
@@ -169,15 +174,16 @@ object DataSourceV2Relation {
options: Map[String, String],
tableIdent: Option[TableIdentifier] = None,
userSpecifiedSchema: Option[StructType] = None):
DataSourceV2Relation = {
- val reader = source.createReader(options, userSpecifiedSchema)
+ val readSupport = source.createReadSupport(options,
userSpecifiedSchema)
--- End diff --
Another point is which schema you would expect the datasource return in
that case. For instance, `spark.range(1).write.format("source").save()`. It's
odd that `source` should provide a schema. I mean it's logically weird. How
does the source provide the schema?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
